Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Delete unused pypi repository rules #20578

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Nov 23, 2023

Towards #14967.


This change is Reviewable

These were useful years ago, but today the rules_python wrappers
around pip are vastly superior to this infrastructure.
@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: none This pull request should not be mentioned in the release notes labels Nov 23, 2023
@jwnimmer-tri
Copy link
Collaborator Author

+@rpoyner-tri for both reviews, please.

I've confirmed these are long-since unused in Anzu as well.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform)

@jwnimmer-tri
Copy link
Collaborator Author

All CI passed, but looks like some webhook messages got dropped. Forcing in now.

@jwnimmer-tri jwnimmer-tri merged commit 49c550f into RobotLocomotion:master Nov 27, 2023
1 check passed
@jwnimmer-tri jwnimmer-tri deleted the os-portability-pypi branch November 27, 2023 15:58
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 27, 2023
These were useful years ago, but today the rules_python wrappers
around pip are vastly superior to this infrastructure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants